[v1.4] Fix calibration in telemetry health #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… params are received, but when hitl is enabled
julianoes
approved these changes
Sep 11, 2023
julianoes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calibration check should be stopped when the drone is actually found to be running in hitl mode, and not when the hitl param is received (because the hitl param may say that the drone is not running hitl, in which case we need to continue checking the calibration).
Without this fix, the health booleans related to the calibration tend to be "stuck" on the default
falsevalue (because MAVSDK stops checking and never gets to the point where it realizes that the check is actually fine).