Add battery status message for v1 #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @julianoes and @JonasVautherin ready for a review :) For the proto check, I guess it requires to update the proto submodule but we need to merge in MAVSDK proto first right ? |
Katawann
changed the title
|
Hi @julianoes, any chance we could merge this pull request ? |
JonasVautherin
requested changes
Jan 11, 2023
|
Does it request an update of |
Yes but should it be merged first so than I can update it ? mavlink/MAVSDK-Proto#297 |
- temperature in degree Celsius - current battery in A - capacity consumed in Ah
Signed-off-by: Julian Oes <[email protected]>
|
Thanks @Katawann and sorry it took so long. |
|
Any plan for a big release soon (including this feature) ? Otherwise I will build this modification on top of v1.4.10 next week |
|
I'm hoping for end of Feb for v2. |
|
Ok cool ! Thanks for the answer. Looking forward to it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the new messages in MAVSDK-Proto, it is required to implement the logic and conversion if necessary of the battery status. New messages are:
Depends on mavlink/MAVSDK-Proto#297.