use 'thiserror' to derive errors #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danieleades
force-pushed
the
refactor/derive-thiserror
branch
from
e7022cd
to
d248b26
Compare
danieleades
force-pushed
the
refactor/derive-thiserror
branch
from
406e6b4
to
fedb1dd
Compare
|
@julianoes are you happy for me to merge this one? |
|
@danieleades yes just merge as you want. I currently don't have capacity to look into this Rust repo, and I'm just happy that you do. I am interested in it though and I want to read through it and try it out at some point. |
no worries! I've held off on #31 for now, that's one i'd like some input on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.