Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client,bridgev2: Add support for MSC4190 #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

client,bridgev2: Add support for MSC4190 #288

wants to merge 1 commit into from
+50 −5

Conversation

onestacked
Copy link

@onestacked onestacked commented Sep 20, 2024 •
edited
Loading

Adds MSC4190 support.

tulir
tulir reviewed Sep 22, 2024
View reviewed changes
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config option goes in bridgev2/bridgeconfig + bridgev2/matrix/mxmain/example-config.yaml (no need to update the legacy bridge module)

SetAppServiceDeviceID probably also has to be set in the e2ee client

@onestacked onestacked changed the title Try adding support for MSC4190 client,bridgev2: Add support for MSC4190 Sep 22, 2024
@onestacked onestacked marked this pull request as ready for review September 22, 2024 19:32
@onestacked
Copy link
Author

I've now added the config flag in bridgev2 and removed some changes not needed for bridgev2.

I've tested this with element-hq/synapse#17705 and MSC3861.
Requires msc3202_device_masquerading: true to be set in the synapse config.

This was referenced Sep 22, 2024
Draft
Open
@onestacked onestacked mentioned this pull request Sep 23, 2024
Open
tulir
tulir approved these changes Sep 28, 2024
View reviewed changes
bridgev2/bridgeconfig/legacymigrate.go Outdated Show resolved Hide resolved
@onestacked

This comment was marked as resolved.

Sign in to view
@onestacked
Copy link
Author

Can this be merged?

@onestacked
Copy link
Author

@tulir Friendly ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onestacked @tulir