Fix JIRA backups #21
Merged
Fix JIRA backups #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on commit 610e426885ea1 in that repository URL: https://bitbucket.org/atlassianlabs/automatic-cloud-backup Signed-off-by: Samuli Seppänen <[email protected]>
|
Fixes #19 for JIRA at least. As said, Confluence backups seem to still work with cookies. |
|
Thanks @mattock , i try to test this PR this week. I have some urgent work here. |
|
@dzschille I'll merge this as-is. We use it in production, it works and does not affect any existing functionality. If there are any issues with it we can fix them later. |
|
Thanks! I'm too busy at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports Atlassian's new backup-jira-api-token.sh script as-is, then add supports for loading the parameters from the config file (e.g. /root/.backup.sh.vars) and then makes timestamping the output file optional.
The backup-jira-api-token.sh script does not yet support disabling download of attachments using variables / command-line switches, but adding that feature would be easy.
The old JIRA backup option is still present in backup.sh, but that should be ripped off later as it does not work. Confluence backups still seem to work with the old script, though.