Display any errors returned by npm ls --production --parseable
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a variety of scenarios in which `npm ls` will return a non-zero exit code and the output will include error messages. In order to aid with debugging it is useful to be able to see these error messages. The changes introduced in PR #105 had the effect of silencing errors completely. This change ensures that if the `npm ls` command was successful, but the output contains some lines that aren't filepaths e.g. loglevel info output, they will be stripped out, but that in the case of `npm ls` returning an error, you will be able to see it in the output displayed by `shellpromise`.
|
I wasn't sure of a good way to add a test for this. Suggestions welcome! |
|
this may interest you matthew-andrews/shellpromise#8 |
|
https://github.com/sindresorhus/execa is also much more configurable in this regard, returning a promise with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a variety of scenarios in which
npm lswill return a non-zero exit code and the output will include error messages. In order to aid with debugging it is useful to be able to see these error messages. The changes introduced in PR #105 had the effect of silencing errors completely.This change ensures that if the
npm lscommand was successful, but the output contains some lines that aren't filepaths e.g. loglevel info output, they will be stripped out, but that in the case ofnpm lsreturning an error, you will be able to see it in the output displayed byshellpromise.