MM-60769: load from s3 #1629
Merged
MM-60769: load from s3 #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifoukarakis
force-pushed
the
MM-60769-load-from-s3
branch
from
5ec3a17
to
4407652
Compare
ifoukarakis
added
Work In Progress
utils/packets/aws.py
Outdated
| return False | ||
|
|
||
|
|
||
| # The bucket does not exist or you ha |
There was a problem hiding this comment.
Left over. Removing.
| from utils.packets.service import ingest_support_packet, ingest_survey_packet | ||
| from utils.packets.service import ( | ||
| ingest_support_packet, | ||
| ingest_support_packets_from_s3, |
There was a problem hiding this comment.
I assume there is no need to add tests for ingest_support_packets_from_s3 (only the table name changes).
There was a problem hiding this comment.
It's calling the same function as ingest_surveys_from_s3. The individual components have been tested. We can add an end-to-end test if you prefer. However, since there might be changes depending on the structure of the S3 bucket, I prefer to wait for them before adding the extra data.
catalintomai
approved these changes
Oct 14, 2024
ifoukarakis
force-pushed
the
MM-60769-load-from-s3
branch
from
4407652
to
ee2ddf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assumes that different types of packets are under
<prefix>/YYYY/MM/DD/.Ticket Link
https://mattermost.atlassian.net/issues/MM-60769