Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swiftsdk): swift sdk scaffolding #38

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat(swiftsdk): swift sdk scaffolding #38

merged 1 commit into from
Dec 13, 2024

Conversation

jackpooleyml
Copy link
Contributor

@jackpooleyml jackpooleyml commented Dec 11, 2024 •
edited
Loading

Description

Adds basic scaffolding for the Swift SDK including:

  • A Swift Package and example app
  • Rust crate scaffolding with a basic uniffi-rs binding generation setup and the alloy-zksync dependency added
  • A basic Swift CI pipeline

@jackpooleyml jackpooleyml requested a review from cpb8010 December 11, 2024 17:13
@cpb8010 cpb8010 added the good first issue Good for newcomers label Dec 11, 2024
@jackpooleyml jackpooleyml force-pushed the jack/swift branch 4 times, most recently from 4ebf159 to 1133ca5 Compare December 11, 2024 17:43
@jackpooleyml jackpooleyml marked this pull request as ready for review December 11, 2024 17:44
@jackpooleyml jackpooleyml force-pushed the jack/swift branch 10 times, most recently from 72222c1 to 6ab589f Compare December 13, 2024 16:52
MexicanAce
MexicanAce previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackpooleyml jackpooleyml merged commit dda9ebe into main Dec 13, 2024
6 checks passed
@jackpooleyml jackpooleyml deleted the jack/swift branch December 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

@cpb8010 cpb8010 Awaiting requested review from cpb8010

@itsacoyote itsacoyote Awaiting requested review from itsacoyote

@ly0va ly0va Awaiting requested review from ly0va

@JackHamer09 JackHamer09 Awaiting requested review from JackHamer09

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpooleyml @MexicanAce @cpb8010