Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sdk to use latest contracts version #34

Merged
merged 14 commits into from
Dec 12, 2024
Merged

Conversation

JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Dec 8, 2024

Description

  • Update SDK to support new contracts interface for period limits
  • Fix incorrect constraint refValue formatting causing session creation crash

Additional context

  • Timestamp asserter address should be updated in the contracts
  • Deploy/Upgrade contracts and update addresses before merging the PR

Copy link

github-actions bot commented Dec 8, 2024

Visit the preview URL for this PR (updated for commit 4f94b1e):

https://zksync-auth-server-staging--pr34-use-latest-contracts-vm0a0y4y.web.app

(expires Thu, 19 Dec 2024 13:08:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@JackHamer09 JackHamer09 requested a review from ly0va December 9, 2024 10:16
@JackHamer09 JackHamer09 marked this pull request as draft December 9, 2024 15:12
@MexicanAce MexicanAce marked this pull request as ready for review December 12, 2024 11:47
Copy link
Contributor

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ly0va ly0va merged commit c10812a into main Dec 12, 2024
7 checks passed
@ly0va ly0va deleted the use-latest-contracts branch December 12, 2024 13:13
itsacoyote pushed a commit that referenced this pull request Dec 12, 2024
* fix: update sdk to use latest contracts version

* fix: update package lock file

* fix: restructure sdk client files

* fix: update contracts

* fix: update package lock file

* fix: update addresses

* fix: update addresses, for some reason ci deploys to different addresses

* fix: hmmmm use latest working contracts version

* fix: update contracts version and latest deployment contracts interface

* fix: update contracts addresses

* fix: update sdk to match latest contracts interface

* fix: increase fee limit for nft quest

* chore: bump contracts to use upgradeable factory

* chore: update testnet addresses

---------

Co-authored-by: Lyova Potyomkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants