-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update sdk to use latest contracts version #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 4f94b1e): https://zksync-auth-server-staging--pr34-use-latest-contracts-vm0a0y4y.web.app (expires Thu, 19 Dec 2024 13:08:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
MexicanAce
reviewed
Dec 12, 2024
MexicanAce
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
itsacoyote
pushed a commit
that referenced
this pull request
Dec 12, 2024
* fix: update sdk to use latest contracts version * fix: update package lock file * fix: restructure sdk client files * fix: update contracts * fix: update package lock file * fix: update addresses * fix: update addresses, for some reason ci deploys to different addresses * fix: hmmmm use latest working contracts version * fix: update contracts version and latest deployment contracts interface * fix: update contracts addresses * fix: update sdk to match latest contracts interface * fix: increase fee limit for nft quest * chore: bump contracts to use upgradeable factory * chore: update testnet addresses --------- Co-authored-by: Lyova Potyomkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context