Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename zkstack crates with unique names for publishing #3443

Merged
merged 1 commit into from
Jan 9, 2025
Merged

refactor: rename zkstack crates with unique names for publishing #3443

merged 1 commit into from
Jan 9, 2025

Conversation

antonbaliasnikov
Copy link
Contributor

What ❔

  • Rename zkstack_cli crates with unique names for publishing.
  • Set individual versions of the zkstack_cli workspace crates to the common workspace version.

Why ❔

To allow publishing to crates.io.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

popzxc
popzxc reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename it to zkstack_cli_* (because zkstack as a term has different meaning)?

@antonbaliasnikov antonbaliasnikov force-pushed the aba-rename-zkstack-cli-crates branch from 4a4ed74 to 4781e93 Compare January 8, 2025 15:21
@antonbaliasnikov antonbaliasnikov force-pushed the aba-rename-zkstack-cli-crates branch from 4781e93 to 634b04e Compare January 8, 2025 15:22
@antonbaliasnikov
Copy link
Contributor Author

Could you rename it to zkstack_cli_* (because zkstack as a term has different meaning)?

@popzxc , sure! Reworked to zkstack_cli_*.

@popzxc popzxc added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@popzxc popzxc added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@popzxc popzxc added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@popzxc popzxc added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 7adb612 Jan 9, 2025
31 checks passed
@popzxc popzxc deleted the aba-rename-zkstack-cli-crates branch January 9, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonbaliasnikov @popzxc