feat(contracts)!: synclayer integration #1934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavBreadless
force-pushed
the
sync-layer-stable
branch
from
d01dded to
66d262d
Compare
StanislavBreadless
changed the title
Detected VM performance changes
Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently. |
|
Folks, this PR is getting scary each passing day. What's the plan to integrate it? |
perekopskiy
reviewed
Sep 10, 2024
core/lib/dal/migrations/20240807102710_l2_da_validator_in_batch.up.sql
Outdated
Show resolved
Hide resolved
core/lib/dal/migrations/20240830085550_add_eth_watcher_progress_table.up.sql
Outdated
Show resolved
Hide resolved
| state_diff_hash: H256::from_slice( | ||
| &batch | ||
| .state_diff_hash | ||
| .ok_or(L1BatchMetadataError::Incomplete("state_diff_hash"))?, |
There was a problem hiding this comment.
returning error on missing state_diff_hash is disruptive, old batches can still be queried
kelemeno
reviewed
Sep 18, 2024
core/node/state_keeper/src/io/seal_logic/l2_block_seal_subtasks.rs
Outdated
Show resolved
Hide resolved
feat: Enable fee projection tests
…ra-private into sync-layer-stable
chore: merge main and conflicts
feat: Support for non standard base token
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
chore: Merge main into sync-layer-stable
## What ❔ Update contracts + remove unneeded changes ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
chore: Merge main into sync layer stable
## What ❔ sync with main ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
## What ❔ some non-functional changes ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
## What ❔ sync with main ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
…_gateway (#3448) ## What ❔ * Updated contracts to most recent one (including PR 1187 from contracts) * Added transaction hashes to the upgrade yaml file - so that tools can verify bytecodes * fix to governance_upgrade_timer_initial_delay - it was missing before. --------- Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This is a semi-stable branch for sync layer integration. It is still WIP and big changes are expected
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.