Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant license file, and updated invalid pacakge.json "license" field. #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

golgobot
Copy link

@golgobot golgobot commented Jul 8, 2019

According to the npm's package.json documentation:

Some old packages used license objects or a “licenses” property containing an array of license objects ... Those styles are now deprecated. Instead, use SPDX expressions, like this:

{ "license": "ISC" }
{ "license": "(MIT OR Apache-2.0)" }

This is an issue because many companies will not include this package in its internal npm registry mirror unless it uses an approved license. Because the license field is malformed, npm reports this package as have license type "none", so it's excluded from the internal mirror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant