Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

donate.html: regularize URLs & text with docs/donate.html #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filbo
Copy link
Collaborator

@filbo filbo commented Jun 5, 2023

  • URLs (cash.me => cash.app, Patreon & GoFundMe HTTPS) were changed in src commit 974d43f, 2019-05-01
  • 'Do you appreciate' text changed in src commit cf464ff, 2020-09-28
  • 'Spring Break trip' text changed in src commit 901d0af, 2022-12-27
  • 'Flattr' was removed in src commit 901d0af, 2022-12-27
  • 'BitCoin' was removed in src commit 901d0af, 2022-12-27
  • moved 'GoFundMe' to the right-side for symmetry

I didn't remove, only commented out (hid with 'display:none') Flattr & BitCoin; and did not attempt to add VenMo, not wanting to deal with the inline image stuff right now.

... prepping to add my donate info to wrench > Options > Donate ...

HOWEVER, first will try to talk Matt into just changing it to open socialfixer.com/donate in a new browser tab, so this stuff doesn't need to be clumsily duplicated :)

 - URLs (cash.me => cash.app, Patreon & GoFundMe HTTPS) were changed
   in src commit 974d43f, 2019-05-01
 - 'Do you appreciate' text changed in src commit cf464ff, 2020-09-28
 - 'Spring Break trip' text changed in src commit 901d0af, 2022-12-27
 - 'Flattr' was removed in src commit 901d0af, 2022-12-27
 - 'BitCoin' was removed in src commit 901d0af, 2022-12-27
 - moved 'GoFundMe' to the right-side for symmetry

I didn't remove, only commented out (hid with 'display:none') Flattr &
BitCoin; and did not attempt to add VenMo, not wanting to deal with the
inline image stuff right now.

... prepping to add my donate info to wrench > Options > Donate ...

HOWEVER, first will try to talk Matt into just changing it to open
socialfixer.com/donate in a new browser tab, so this stuff doesn't
need to be clumsily duplicated :)
@filbo filbo requested a review from matt-kruse June 5, 2023 09:26
@filbo
Copy link
Collaborator Author

filbo commented Jun 5, 2023

I'll commit this after a few days if I don't hear from you. It changes the wrench > Options > Donate text and donation methods to more closely match socialfixer.com/donate; with two major exceptions:

  • didn't add VenMo
  • didn't add my own stuff (yet)

It removes 'Flattr' and 'BitCoin', which you removed some months ago from the web page.

I'd prefer to change the extension menu choice to just open socialfixer.com/donate in a new browser tab. These two files don't get maintained in sync and needing to inline the images is just fugly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant