Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using SdkHttpConfigurationOption over default akka-http connection settings #255

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jtjeferreira
Copy link
Contributor

introduce withConnectionPoolSettingsBuilder and withConnectionPoolSettingsBuilderFromAttributeMap to allow the usage of AWS SDK configuration options

This change is introduced in a backwards compatible change. To use the new functionality withConnectionPoolSettingsBuilderFromAttributeMap should be used. Check the unit tests for examples

Fixes #232

@pjfanning
Copy link

pjfanning commented Sep 24, 2024

@jtjeferreira when you get this working, would you mind also doing a PR for https://github.com/apache/pekko-connectors which has a Pekko version of this code (in a module)?

@jtjeferreira
Copy link
Contributor Author

@jtjeferreira when you get this working, would you mind also doing a PR for apache/pekko-connectors which has a Pekko version of this code (in a module)?

For sure. I thought the pekko fork was in https://github.com/pjfanning/aws-spi-pekko-http/ ...

@pjfanning
Copy link

@jtjeferreira when you get this working, would you mind also doing a PR for apache/pekko-connectors which has a Pekko version of this code (in a module)?

For sure. I thought the pekko fork was in https://github.com/pjfanning/aws-spi-pekko-http/ ...

We've brought it into Apache Pekko Connectors 1.1. I will maintain https://github.com/pjfanning/aws-spi-pekko-http/ for bug fixes because Apache Pekko Connectors 1.0 still use it but there is probably not much point adding enhancements to my fork. In theory, the Apache Pekko Connectors 1.1 copy of this lib should work with Pekko Connectors 1.0 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using SdkHttpConfigurationOption over default akka-http connection settings
2 participants