Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve static type checking #223

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Improve static type checking #223

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17a7850
Improve static type checking
kibablu Apr 29, 2021
4c91528
Add changelog on Improve static type checking #223
kibablu Apr 29, 2021
d102ef6
Fix static type checking
kibablu Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/223.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve static type checking. Contributed by Omar Mohamed.
4 changes: 2 additions & 2 deletions sygnal/apnstruncate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
# Copied and adapted from
# https://raw.githubusercontent.com/matrix-org/pushbaby/master/pushbaby/truncate.py
import json
from typing import List, Tuple, Union
from typing import Any, Dict, List, Tuple, Union


def json_encode(payload):
def json_encode(payload: Dict[str, Any]) -> bytes:
babolivier marked this conversation as resolved.
Show resolved Hide resolved
return json.dumps(payload, ensure_ascii=False).encode()


Expand Down