Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create additional labels when detecting Dendrite or Conduit homeserver #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neilalexander
Copy link

This should make it easier to spot rageshakes related to users running these homeservers. Currently the server_version field is only sent by Element Android though so will need to do something about iOS still.

Some of the formatting is due to running goimports on submit.go so sorry about the noise with that.

@neilalexander neilalexander marked this pull request as ready for review April 25, 2022 14:21
@t3chguy
Copy link
Member

t3chguy commented Apr 25, 2022

Currently the server_version field is only sent by Element Android though so will need to do something about iOS still.

Keep in mind clients have no CS API to ask the server for its version, that's on the federation API only https://spec.matrix.org/v1.2/server-server-api/#get_matrixfederationv1version so is unlikely to get implemented across the board as it'll be brittle due to some clients (web) being unable to perform the SRV lookups required to locate the federation API for a given server

@neilalexander
Copy link
Author

Keep in mind clients have no CS API to ask the server for its version, that's on the federation API only https://spec.matrix.org/v1.2/server-server-api/#get_matrixfederationv1version

Bah, of course. That's annoying.

@richvdh
Copy link
Member

richvdh commented Apr 25, 2022

yeah, I'm a bit 👎 on this change. It feels like it's going to be fragile.

@richvdh richvdh removed their request for review April 27, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants