Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse base64 encoding/decoding methods from vodozemac #2532

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Sep 8, 2023

We have those same base64 decoding/encoding methods defined in multiple places and it's annoying to keep them in sync. Let's define them once and reuse them instead.

Closes: #2531.

@BillCarsonFr if you have a unit test for the bindings feel free to push a commit or pass the commit to me over Matrix.

@poljar poljar requested a review from a team as a code owner September 8, 2023 09:18
@poljar poljar requested review from jplatte and removed request for a team September 8, 2023 09:18
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01% ⚠️

Comparison is base (eb865f4) 77.45% compared to head (cc1e772) 77.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
- Coverage   77.45%   77.45%   -0.01%     
==========================================
  Files         180      180              
  Lines       19361    19357       -4     
==========================================
- Hits        14996    14992       -4     
  Misses       4365     4365              
Files Changed Coverage Δ
...trix-sdk-crypto/src/file_encryption/attachments.rs 79.72% <ø> (ø)
...es/matrix-sdk-crypto/src/olm/signing/pk_signing.rs 95.79% <ø> (ø)
crates/matrix-sdk-crypto/src/store/mod.rs 82.31% <0.00%> (ø)
crates/matrix-sdk-crypto/src/utilities.rs 96.96% <ø> (-0.33%) ⬇️
...atrix-sdk-crypto/src/file_encryption/key_export.rs 97.46% <100.00%> (ø)
crates/matrix-sdk-crypto/src/olm/account.rs 85.67% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@poljar poljar merged commit c32f244 into main Sep 8, 2023
36 checks passed
@poljar poljar deleted the poljar/reuse-base64-config-vodozemac branch September 8, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matrix-sdk-crypto-ffi | Scan QR code method is sensitive to base 64 padding when decoding
2 participants