This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix: Enable previously skipped Playwright crypto test for 'gray shields' #12249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
added
the
T-Task
florianduros
approved these changes
Feb 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26811
The test was incorrectly testing for the presence of a red shield. It was probably expecting a
Message sent from a deleted device.In that case it is true that the sending device is deleted, but the key is coming from the backup. At the moment keys coming from backup can't be linked back to the device that created them (until authenticated backup is implemented).
That's why the shield would be gray. If we can't establish authenticity, we can't make any checks on the device (is signed by it's owner? verified by us? is it deleted?)
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.