Update topenAIChat.m

matlab-deep-learning · Apr 24, 2024 · 751b348 · 751b348
1 parent a62530b
commit 751b348
Showing 1 changed file with 17 additions and 11 deletions.
diff --git a/tests/topenAIChat.m b/tests/topenAIChat.m
@@ -16,9 +16,9 @@ function saveEnvVar(testCase)
     end
 
     properties(TestParameter)
-        InvalidConstructorInput = iGetInvalidConstructorInput;
-        InvalidGenerateInput = iGetInvalidGenerateInput;  
-        InvalidValuesSetters = iGetInvalidValuesSetters;  
+        InvalidConstructorInput = iGetInvalidConstructorInput();
+        InvalidGenerateInput = iGetInvalidGenerateInput();  
+        InvalidValuesSetters = iGetInvalidValuesSetters();  
     end
 
     methods(Test)
@@ -37,10 +37,6 @@ function generateAcceptsMessagesAsInput(testCase)
             testCase.verifyWarningFree(@()generate(chat,messages));
         end
 
-        function constructMdlWithInvalidParameters(testCase)
-            testCase.verifyError(@()openAIChat(ApiKey="this-is-not-a-real-key", ModelName="gpt-4", ResponseFormat="json"), "llms:invalidOptionAndValueForModel");
-        end
-
         function keyNotFound(testCase)
             testCase.verifyError(@()openAIChat, "llms:keyMustBeSpecified");
         end
@@ -115,15 +111,21 @@ function noStopSequencesNoMaxNumTokens(testCase)
             testCase.verifyWarningFree(@()generate(chat,"This is okay"));
         end
 
+        function createOpenAIChatWithStreamFunc(testCase)
+            sf = @(x)fprintf("%s", x);
+            chat = openAIChat(ApiKey="this-is-not-a-real-key", StreamFun=sf);
+            testCase.verifyWarningFree(@()generate(chat, "Hello world."));
+        end
+
         function createOpenAIChatWithOpenAIKey(testCase)
             chat = openAIChat(ApiKey=getenv("OPENAI_KEY"));
-            testCase.verifyWarningFree(@()generate(chat,"Hello world."));
+            testCase.verifyWarningFree(@()generate(chat, "Hello world."));
         end
 
     end    
 end
 
-function invalidValuesSetters = iGetInvalidValuesSetters
+function invalidValuesSetters = iGetInvalidValuesSetters()
 
 invalidValuesSetters = struct( ...
     "InvalidTemperatureType", struct( ...
@@ -227,7 +229,7 @@ function createOpenAIChatWithOpenAIKey(testCase)
         "Error", "MATLAB:notGreaterEqual"));
 end
 
-function invalidConstructorInput = iGetInvalidConstructorInput
+function invalidConstructorInput = iGetInvalidConstructorInput()
 validFunction = openAIFunction("funName");
 invalidConstructorInput = struct( ...
     "InvalidResponseFormatValue", struct( ...
@@ -238,6 +240,10 @@ function createOpenAIChatWithOpenAIKey(testCase)
         "Input",{{"ResponseFormat", ["text" "text"] }},...
         "Error", "MATLAB:validation:IncompatibleSize"), ...
     ...
+    "InvalidResponseFormatModelCombination", struct( ...
+        "Input", {{"ApiKey", "this-is-not-a-real-key", "ModelName", "gpt-4", "ResponseFormat", "json"}}, ...
+        "Error", "llms:invalidOptionAndValueForModel"), ...
+    ...
     "InvalidStreamFunType", struct( ...
         "Input",{{"StreamFun", "2" }},...
         "Error", "MATLAB:validators:mustBeA"), ...
@@ -371,7 +377,7 @@ function createOpenAIChatWithOpenAIKey(testCase)
         "Error","MATLAB:validators:mustBeTextScalar"));
 end
 
-function invalidGenerateInput = iGetInvalidGenerateInput
+function invalidGenerateInput = iGetInvalidGenerateInput()
 emptyMessages = openAIMessages;
 validMessages = addUserMessage(emptyMessages,"Who invented the telephone?");