Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aggregateGroupByDuration API #171

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

taisuke-j
Copy link
Contributor

Summary

Following #157, I have made a similar addition for aggregateGroupByDuration.

Difference between Duration and Period classes in Java:

  • Duration: A fixed length of time (daylight savings effects are ignored)
  • Period: Date-based amount of time (days, weeks, months and years)

AGGREGATE SAMPLE GROUP DATA BY DURATION button: Added the "AGGREGATE SAMPLE GROUP DATA BY DURATION" button, as shown below, to test the aggregateGroupByDuration API.

image

Log after AGGREGATE SAMPLE GROUP DATA BY DURATION button is pressed

# timeRangeSlicer.duration: DAYS
# timeRangeSlicer.length: 2

Aggregated Group by Duration:  {
  "result": [
    {
      "endTime": "2024-10-06T15:00:00Z",
      "startTime": "2024-10-04T15:00:00Z",
      "zoneOffset": "+09:00",
      "result": {
        "dataOrigins": [],
        "COUNT_TOTAL": 3000
      }
    },
    {
      "endTime": "2024-10-08T15:00:00Z",
      "startTime": "2024-10-06T15:00:00Z",
      "zoneOffset": "+09:00",
      "result": {
        "dataOrigins": [],
        "COUNT_TOTAL": 7000
      }
    },
    {
      "endTime": "2024-10-10T15:00:00Z",
      "startTime": "2024-10-08T15:00:00Z",
      "zoneOffset": "+09:00",
      "result": {
        "dataOrigins": [],
        "COUNT_TOTAL": 11000
      }
    },
    {
      "endTime": "2024-10-12T14:57:39.714Z",
      "startTime": "2024-10-10T15:00:00Z",
      "zoneOffset": "+09:00",
      "result": {
        "dataOrigins": [],
        "COUNT_TOTAL": 7000
      }
    }
  ]
}

@taisuke-j
Copy link
Contributor Author

@matinzd This one is almost the same as #157.

@Gytjarek
Copy link

@matinzd Hey! Is there any chance you could merge this soon?

Copy link
Owner

@matinzd matinzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine! I will do a manual testing soon and will merge it.
Can you update the related documentation pages accordingly and also update README about the breaking change?

@matinzd
Copy link
Owner

matinzd commented Oct 24, 2024

Thank you for your contribution 🌸

@matinzd matinzd merged commit 60efc22 into matinzd:main Oct 28, 2024
3 checks passed
@Gytjarek
Copy link

@matinzd Hey! Thank you for merging the PR. Could you let me know when you plan to release a new version with this PR? We’re working on a project, and it’s blocking us from continuing. It would be helpful to know your plans. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants