-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds a new method for requesting exercise permissions #167
feat: adds a new method for requesting exercise permissions #167
Conversation
Will look into this further this weekend |
): Promise<Permission[]> { | ||
return HealthConnect.requestPermission(permissions, providerPackageName); | ||
return HealthConnect.requestPermission(permissions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially replaced this with another arg, then removed the arg in favor of a special permission obj (see src/types/index.ts
). It wasn't doing anything so didn't add it again but can undo the changes for the sake of not breaking anyone's code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed later by myself. By default most people use health connect to get the data, but it should be possible to customize this.
@matinzd Any chance you could take a look at this? I patched our own app and syncing worked as expected. It also touches a few other things that we don't use necessarily so a review would be much appreciated 🙏 |
When do you think we can get to this @matinzd ? If you're busy with other things not a problem but an eta would be super helpful to decide using a patch vs waiting for a proper release and upgrading. |
Hey @ugurakin1 Can you please rebase your branch? |
Done @matinzd |
Hey @matinzd , any updates on this/eta? Also, did you want me to just update so there aren't any conflicts or did you actually want me to rebase instead? |
Hey! I am gonna try to release it this weekend. It doesn't matter, I don't want to see any conflicts. |
Let me know if you need anything from me @matinzd, happy to land a hand 👍 |
android/src/main/java/dev/matinzd/healthconnect/records/ReactExerciseSessionRecord.kt
Outdated
Show resolved
Hide resolved
Hey @matinzd , any chance we can take another look this weekend? |
Massive thanks @matinzd 🙏 |
Changes
requestPermission
to accept an optional flag that indicates requested permissions should includewrite-route
permission. Removed the unusedproviderPackageName
arg from the method as well.Issues
#34