-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DeepFace Library #22
base: master
Are you sure you want to change the base?
Conversation
Since DeepFace only exists as a python library and not as a php library, I feel its addition here is appropriate as it would allow people to use models other than dlib's model with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!. 😄 😃 🎉
The idea of externalizing the models was mainly to invite people to try out other models. And this particular model promises a lot!.
I would be happy to incorporate this model and test it to see the results, but right now I'm focused on publishing the NC30 compatible version. Wait a bit and try to incorporate these small changes
.. 😉
Thanks a lot!!. 😬
return dlib.rectangle( | ||
json["top"], json["right"], json["bottom"], json["left"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you change the order here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the docs, this was the correct order. using the previous order produced issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this would be the documentation for DeepFace, but for dlib models you need the original order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was in the documentation for the dlib rectangle
class
if I then used the top
, bottom
, right
, and left
functons, they return the correct result with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is from the docs:
__init__(*args, **kwargs)
Overloaded function.
__init__(self: dlib.rectangle, left: int, top: int, right: int, bottom: int) -> None
__init__(self: dlib.rectangle, rect: dlib::drectangle) -> None
__init__(self: dlib.rectangle, rect: dlib.rectangle) -> None
__init__(self: dlib.rectangle) -> None
@@ -0,0 +1,19 @@ | |||
[tool.poetry] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know poetry, but I'll see if it's worth leaving these files... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me neither, I'm not a python dev
I just hear it's what people use
Hi easier to say than actually doing it, but if more models are added to the project, maybe the main python file should be split into several files, like a kind of "plugin" system. Poetry is one of the many Python tools to manage virtual environment (deploy, add packages, etc.) and track dependencies of a project. It's a very useful tool |
Adds support for the DeepFace python library.
According to their benchmarks, Facenet512 with the retinaface backend has 76.92% fewer false negatives than dlib's models.
So, just felt I'd add this.
However, the
Dockerfile
still needs to be updated to support the use of poetry.