Merge branch 'no_remote_exception_fix'

src/Repos/FakeLogsRepo.php

@@ -5,8 +5,8 @@
 
 class FakeLogsRepo implements LogsRepoInterface
 {
-    private $config;
-    private $logs;
+    protected $config;
+    protected $logs;
 
     public function __construct(array $config)
     {

src/Repos/FakeRemoteLogsRepo.php

@@ -0,0 +1,15 @@
+<?php namespace MathiasGrimm\LaravelLogKeeper\Repos;
+
+use Exception;
+
+class FakeRemoteLogsRepo extends FakeLogsRepo
+{
+    public function __construct(array $config)
+    {
+        parent::__construct($config);
+
+        if ($this->config['enabled_remote'] && !$this->config['remote_disk']) {
+            throw new Exception("remote_disk not configured for Laravel Log Keeper");
+        }
+    }
+}

src/Repos/RemoteLogsRepo.php

@@ -1,5 +1,6 @@
 <?php namespace MathiasGrimm\LaravelLogKeeper\Repos;
 
+use Exception;
 use \Storage;
 use MathiasGrimm\LaravelLogKeeper\Support\LogUtil;
 
@@ -15,7 +16,7 @@ public function __construct(array $config)
         $this->config = $config;
 
         if ($this->config['enabled_remote'] && !$this->config['remote_disk']) {
-            throw new \Exception("remote_disk not configured for Laravel Log Keeper");
+            throw new Exception("remote_disk not configured for Laravel Log Keeper");
         }
 
         $this->localLogPath = storage_path('logs');
@@ -57,7 +58,7 @@ public function getCompressed()
 
     public function compress($log, $compressedName)
     {
-        throw new \Exception("Method not implemented yet");
+        throw new Exception("Method not implemented yet");
         // TODO: Implement compress() method.
     }
 

tests/Repos/FakeRemoteLogsRepoTest.php

@@ -0,0 +1,29 @@
+<?php
+
+use MathiasGrimm\LaravelLogKeeper\Repos\FakeRemoteLogsRepo;
+
+class FakeRemoteLogsRepoTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function it_throws_exception_when_enable_remote_is_true_and_remote_disk_is_null()
+    {
+        $config = config('laravel-log-keeper');
+
+        $config['enabled_remote'] = true;
+        $config['remote_disk'   ] = null;
+
+        try {
+            $repo = new FakeRemoteLogsRepo($config);
+            $this->fail('It should not get here');
+        } catch (Exception $e) {
+            $this->assertSame('remote_disk not configured for Laravel Log Keeper', $e->getMessage());
+        }
+
+    }
+
+
+
+
+}

tests/Services/LogKeeperServiceTest.php

@@ -226,5 +226,4 @@ public function it_does_nothing_remotely_if_enabled_remote_is_false()
         $this->assertSame(["laravel-today-{$today->toDateString()}.log"], $logs);
         $this->assertSame([], $remoteRepo->getCompressed());
     }
-
-}
+}