added air toml with paths for windows #90
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 43.42% 38.95% -4.47%
==========================================
Files 16 15 -1
Lines 760 706 -54
==========================================
- Hits 330 275 -55
- Misses 386 399 +13
+ Partials 44 32 -12 ☔ View full report in Codecov by Sentry. |
air_windows.toml
Outdated
| @@ -0,0 +1,46 @@ | |||
| root = "." | |||
There was a problem hiding this comment.
Let's rename this file to .air_windows.toml - Keeps it hidden for the linux guys
There was a problem hiding this comment.
You renamed the file and pushed the new name, but this is still here! You can push the "removed" file from git, it should appear as deleted when you do a git status - just do git add .ait_windows.toml after the deletion, and the commit it after that.
Makefile Windows
Outdated
| @@ -0,0 +1,34 @@ | |||
| # Go parameters | |||
| GOCMD=go | |||
| TEMPL=templ | |||
There was a problem hiding this comment.
This file isn't necessary on windows, Makefile isn't usually standard on windows, as long as the .air_windows.toml file is right, we shouldn't need this one 😄
There was a problem hiding this comment.
TL;DR let's remove this from the PR
urchin_windows_config.toml.exe
Outdated
| @@ -0,0 +1,41 @@ | |||
| # Address to the MariaDB database | |||
There was a problem hiding this comment.
This doesn't seem to have any windows-only changes from the urchin_config.toml file - do we need this? If not, we can also remove from PR
There was a problem hiding this comment.
Windows reads the config.toml only as a .exe in order to run Air. =)
There was a problem hiding this comment.
I think you're mistaken here, this file is running from urchin so as long as --config urchin_config.toml is passed to urchin you should be fine. That's why I don't think we need this here.
For example, in your .air_windows.toml you just need
full_bin = ".\\tmp\\urchin.exe --config urchin_config.toml"
urchin_windows_config.toml.exe
Outdated
| @@ -0,0 +1,41 @@ | |||
| # Address to the MariaDB database | |||
There was a problem hiding this comment.
I think you're mistaken here, this file is running from urchin so as long as --config urchin_config.toml is passed to urchin you should be fine. That's why I don't think we need this here.
For example, in your .air_windows.toml you just need
full_bin = ".\\tmp\\urchin.exe --config urchin_config.toml"
| ``` | ||
|
|
||
| This will start Urchin on `http://localhost:8080`. You can customize | ||
| This will start CMS FOR GO on `http://localhost:8080`. You can customize |
There was a problem hiding this comment.
Did you mean to push these changes to the PR? I think these shouldn't be here
air_windows.toml
Outdated
| @@ -0,0 +1,46 @@ | |||
| root = "." | |||
There was a problem hiding this comment.
You renamed the file and pushed the new name, but this is still here! You can push the "removed" file from git, it should appear as deleted when you do a git status - just do git add .ait_windows.toml after the deletion, and the commit it after that.
Makefile Windows
Outdated
| @@ -6,7 +6,7 @@ URCHIN_DIR=./cmd/urchin | |||
| URCHIN_ADMIN_DIR=./cmd/urchin-admin | |||
|
|
|||
| # Name of the binary | |||
| BINARY_NAME=urchin | |||
| BINARY_NAME=urchin.exe | |||
There was a problem hiding this comment.
I still don't think we need this Makefile Windows file - the windows .air_windows.toml file doesn't reference it at all.
| @@ -3,10 +3,10 @@ testdata_dir = "testdata" | |||
| tmp_dir = "tmp" | |||
|
|
|||
| [build] | |||
| cmd = "make build" | |||
| cmd = "go build -v -o .\\tmp\\urchin.exe .\\cmd\\urchin" | |||
There was a problem hiding this comment.
I think you pushed this as a mistake too
No description provided.