Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release numpy <2 pin, and support python 3.13 #719

Merged
merged 9 commits into from
Dec 10, 2024
Merged

release numpy <2 pin, and support python 3.13 #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a2f2dc
release numpy <2 pin
DanielYang59 Oct 22, 2024
3753d5e
TEST: to show error
DanielYang59 Oct 22, 2024
a264fb8
revert pin
DanielYang59 Oct 22, 2024
c1639c0
drop torch pin
DanielYang59 Oct 23, 2024
d7a6d02
try to test python 3.13
DanielYang59 Oct 23, 2024
7c39f8f
exclude torch for python 3.13
DanielYang59 Oct 23, 2024
0a3b012
exclude pint
DanielYang59 Oct 23, 2024
82f6dd1
limit upper python version
DanielYang59 Oct 23, 2024
89c03fe
maximize test coverage as monty test is pretty cheap
DanielYang59 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ jobs:
fail-fast: false
max-parallel: 20
matrix:
os: [ubuntu-latest, macos-14, windows-latest]
python-version: ["3.9", "3.12"]
os: [windows-latest, ubuntu-latest, macos-latest]
python: ["3.9", "3.10", "3.11", "3.12", "3.13"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just maximize test coverage as monty test is super cheap (only a few seconds), also it's pretty lower level so we cannot afford it to break


runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
- name: Set up Python ${{ matrix.python }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ matrix.python }}

- name: Install dependencies
run: |
Expand Down
10 changes: 6 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ maintainers = [
]
description = "Monty is the missing complement to Python."
readme = "README.md"
requires-python = ">=3.9"
requires-python = ">=3.9,<=3.13"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume setting an upper bound would be a good idea to avoid installation on unverified versions when new python release come out

classifiers = [
"Programming Language :: Python :: 3",
"Development Status :: 4 - Beta",
Expand All @@ -20,7 +20,7 @@ classifiers = [
]
dependencies = [
"ruamel.yaml",
"numpy<2.0.0",
"numpy",
DanielYang59 marked this conversation as resolved.
Show resolved Hide resolved
]
version = "2024.10.21"

Expand All @@ -43,8 +43,10 @@ json = [
"orjson>=3.6.1",
"pandas",
"pydantic",
"pint",
"torch",
# https://github.com/hgrecco/pint/issues/2065
"pint; python_version<'3.13'",
# Note: need torch>=2.3.0 for numpy 2 # 719
"torch; python_version<'3.13'", # python 3.13 not supported yet
]
multiprocessing = ["tqdm"]
optional = ["monty[dev,json,multiprocessing,serialization]"]
Expand Down
Loading