Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem like per-task plots are being regenerated correctly? #259

Open
ardunn opened this issue May 17, 2023 · 5 comments
Open

Doesn't seem like per-task plots are being regenerated correctly? #259

ardunn opened this issue May 17, 2023 · 5 comments
Labels
docs Anything having to do with changes to the documentation

Comments

@ardunn
Copy link
Collaborator

ardunn commented May 17, 2023

https://matbench.materialsproject.org/Leaderboards%20Per-Task/matbench_v0.1_matbench_mp_is_metal/

For example, matformer shows up on the table but not in the figure.

@ardunn ardunn added the docs Anything having to do with changes to the documentation label May 17, 2023
@ardunn
Copy link
Collaborator Author

ardunn commented May 17, 2023

image
but
image

@hrushikesh-s
Copy link
Collaborator

When I clone the repo and try rebuilding the website on a local server by running scripts/rebuild_docs.py and having mkdocs serve running in another terminal, I'm able to get the correct figure (see below).

Is there a way to rebuild the official website without making any changes to the repo?

image

@ardunn
Copy link
Collaborator Author

ardunn commented May 17, 2023

When I clone the repo and try rebuilding the website on a local server by running scripts/rebuild_docs.py and having mkdocs serve running in another terminal, I'm able to get the correct figure (see below).

Is there a way to rebuild the official website without making any changes to the repo?

image

Well we can rebuild it locally (mkdocs build) and then push it, and then cancel the rebuild_docs GH action workflow.

But really I'm interested in why it's not regenerating automatically, otherwise we'll have to manually fix this stuff all the time

@hrushikesh-s
Copy link
Collaborator

I'm trying to setup the rebuild_docs GH action workflow in my forked repo and was looking to change the matbench's website to a temporary github hosted website.

I was expecting that this modification can be made by editing the site_url tag in mkdocs.yml, but there isn't any such tag there.

@ardunn , any idea how can I setup the GH action workflow in my forked repo without messing around with the actual website?

@ardunn
Copy link
Collaborator Author

ardunn commented Jun 27, 2023

I'm trying to setup the rebuild_docs GH action workflow in my forked repo and was looking to change the matbench's website to a temporary github hosted website.

I was expecting that this modification can be made by editing the site_url tag in mkdocs.yml, but there isn't any such tag there.

@ardunn , any idea how can I setup the GH action workflow in my forked repo without messing around with the actual website?

@hrushikesh-s sorry just saw this now. I think you can just enable GH actions on your own fork and have them run?

otherwise, I am pretty sure you can enable them to run for a specific branch on matbench as well. Having a staging branch might be a thing worth doing. Maybe try doing it on your fork and if that doesn't work we can look into enabling it for a different matbench branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Anything having to do with changes to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants