Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to upgrade to newer version of EndBug add-and-commit soon, as features from v7 are being deprecated #260

Open
ardunn opened this issue May 17, 2023 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@ardunn
Copy link
Collaborator

ardunn commented May 17, 2023

https://github.com/EndBug/add-and-commit

@ardunn ardunn added the dependencies Pull requests that update a dependency file label May 17, 2023
@hrushikesh-s
Copy link
Collaborator

It looks like only this line needs to be updated. As described here, I'm setting up the GH Action for my forked repo. Will check for potential errors upon upgrading the add-and-commit from v7 to v9.1.3, once I successfully setup the GH action.

Also, I'd a conversation with @janosh who suggested that we may push directly using git. for eg: this.
@ardunn , is there any specific reason for using EndBug/add-and-commit?

@ardunn
Copy link
Collaborator Author

ardunn commented Jun 10, 2023

@hrushikesh-s yes, it's so there is never a scenario where the docs/website don't represent the actual benchmark data.

Without this commit and push action, the workflow for updating looks like this:

  1. Developer merges in benchmark PR.
  2. Developer pulls repo changes to local branch
  3. Developer regenerates documents
  4. Developer pushes docs to GitHub
  5. GitHub deploys website

With this commit and push action, the workflow for updating looks like this (in theory, in practice it occasionally breaks):

  1. Developer merges in benchmark PR.
  2. GitHub automatically regenerates docs and deploys updated website.

With that in mind, I'm open to other ways of managing this. I just want the website and the bmark data to be in sync to avoid developer (ie, us) headache. Suggestions? @janosh @hrushikesh-s

@ardunn
Copy link
Collaborator Author

ardunn commented Jun 10, 2023

Oh, I did not see that link you posted essentially takes care of the problem. If we can put in a workflow script to take care of it automatically, I'm fine with that. I just want it to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants