Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meson support #3

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Add meson support #3

merged 3 commits into from
Dec 22, 2023

Conversation

Sunderland93
Copy link
Contributor

Meson is much simpler and make packaging a lot easier. See #2

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a test build/install to a redirected destination directory
sudo DESTDIR=/home/luke/Desktop/TEST ninja -C build install
all files went to their expected places.

Running
ninja -C build uninstall
fully cleaned out the test destination directory, with no unwanted leftovers. A test with extra files
intentionally added to the created directorys also worked, with ninja not removing the files it did not
add, and leaving the non-empty directories as intended.

We still need to recompile schemas after installing the gsettings overrride, then this will be ready to go.

In autotools the relevent lines are

install-exec-local:
	glib-compile-schemas $(datadir)/glib-2.0/schemas

and at uninstall we run that second line again.

Thank you for doing this, if I knew the meson/ninja build system better I would have included this myself. If necessary, I can research how to run a script from meson/ninja at install time, merge this, then add the schema recompile in a separate commit.

@Sunderland93
Copy link
Contributor Author

We still need to recompile schemas after installing the gsettings overrride, then this will be ready to go.

I added a script for glib-compile-schemas, please test it

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The post install script works, this is ready to go

@lukefromdc lukefromdc merged commit f998c27 into mate-desktop:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants