terminal-screen: Allow passing of right click to applications #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the popup menu is shown for all right clicks that don't have Ctrl, Alt, or Shift. This is the opposite of what is done in every other terminal. The right click should go to the underlying application except when a special modifier is used. Gnome utilizes Shift as the modifier and LXDE uses Ctrl as their modifier. Referencing gnome-terminal-3.40: https://github.com/GNOME/gnome-terminal/blob/gnome-3-40/src/terminal-screen.c#L1779C1-L1811C16 we can port this logic over and then we achieve exactly what we are looking for. If there is no application, the terminal handles the right click normally. If there is an application, the click gets passed through unless Shift is held. Closes mate-desktop#388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the popup menu is shown for all right clicks that don't have Ctrl, Alt, or Shift. This is the opposite of what is done in every other terminal. The right click should go to the underlying application except when a special modifier is used. Gnome utilizes Shift as the modifier and LXDE uses Ctrl as their modifier.
Referencing gnome-terminal-3.40:
https://github.com/GNOME/gnome-terminal/blob/gnome-3-40/src/terminal-screen.c#L1779C1-L1811C16 we can port this logic over and then we achieve exactly what we are looking for. If there is no application, the terminal handles the right click normally. If there is an application, the click gets passed through unless Shift is held.
Closes #388