RDA: Don't apply stored monitor configuration if session is remote. #306
Conversation
| @@ -2407,6 +2411,12 @@ apply_intended_configuration (MsdXrandrManager *manager, const char *intended_fi | |||
| GError *my_error; | |||
| gboolean result; | |||
|
|
|||
| #ifdef HAVE_RDA | |||
| if (rda_session_is_remote()) { | |||
There was a problem hiding this comment.
Respect code style. File doesn't use tabs.
|
Any updates on this or should we close it? Tabs need to go, and conflict needs to be fixed to continue with it |
|
This is actually worth finishing, so as to avoid risk of invalidating someone's local monitor setup during a remote connection |
Yes, please. If the only concern is white SPACE fixes, just re-indent and merge ? |
|
Note that since this is on someone else's repo, I cannot fix the tab issue or manually apply the changes to conflicting files on this PR. Instead I have to copy it and submit it as a new PR and close this one. We havn't heard from anyone else on the team about this in over four years, nobody has reviewed it functionally, and I never use remote sessions myself and have never been able to test them. I don't think merging untested changes is a good idea |
With remote sessions (like X2Go, xRDP, etc.) the xRandR configuration is normally handled by the remote desktop technology in use.
This change adds a return early to MATE's xrandr MSD monitor resolution restoring code path, if the session is remote.
Note: this PR requires a new build dependency on librda [1]
[1] https://github.com/ArcticaProject/librda.git