Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure.ac: Prevent sh breakage #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

configure.ac: Prevent sh breakage #77

wants to merge 1 commit into from

Conversation

immolo
Copy link

@immolo immolo commented Dec 19, 2023

These should be = not == or it's going to break with dash as /bin/sh.

Thanks-to: Sam James [email protected]

@immolo
configure.ac: Prevent sh breakage
4ceb97b 
These should be = not == or it's going to break with dash as /bin/sh.

Thanks-to: Sam James <[email protected]>
Signed-off-by: Ian Jordan <[email protected]>
lukefromdc
lukefromdc reviewed Dec 23, 2023
View reviewed changes
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just got successful builds of mate-polkit in dash from both git master and with this applied. Not sure which is correct for dash but the change does work. Maybe differences in dash version explain my successful build in master? I have dash 0.5.7 installed

@immolo
Copy link
Author

immolo commented Dec 23, 2023

We use 0.5.11.5 and 0.5.12 in Gentoo so the version difference makes sense here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukefromdc lukefromdc lukefromdc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@immolo @lukefromdc