Fix panel applet keyboard focus trap

[lukefromdc]

Do not open the context menu on tab-or on anything but the menu key. Note that Return must be used by some applets (e.g. the clock) for something else. Fixes #952

[lukefromdc]

Indent fix force-pushed

[cwendling]

Looks reasonable.
Small comments inline.

[lukefromdc]

I think I found the source of the indent confusion: original code used tabs, and I used spaces in the first try, so when someone opened the file in a different editor the bracket moved. Often I do not easily see this sort of thing, as I will only ever see it in pluma, the website, and sometimes in git gui. We normally use spaces, so I used them by mistake without checking to see if tabs had been used.

[lukefromdc]

Also confirm GDK_KEY_Menu works, force-pushed with this and a second indent fix. Thanks for finding those, they can be a source of distraction later if missed.

[lukefromdc]

I force-pushed again. In pluma with tabs used again as in the original code it looked normal from here. Feel free to push any fixes yourself as sometimes I simply cannot see this.

…

On 5/8/2019 at 9:10 AM, "raveit65" ***@***.***> wrote: Hmm, where is the indent fix? https://github.com/mate-desktop/mate-panel/pull/958.diff -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #958 (comment)- 490479532

[lukefromdc]

The indent fix was NOT to any existing code but rather to earlier (superseded by force-push) versions of this PR. I had originally used spaces to position the closing bracket, but the original code around it had tabs, thus leading to wrong position when opened by someone in (presumably) a different editor that didn't give the same tab width. I messed up the first attempt to fix it and had to fix it again to get the closing bracket in the if block level with the if statement

[raveit65]

Using spaces stops pain with tabs :)

[raveit65]

This works great now.
I can navigate with the keyboard trough all applets on vertical and horizontal panels.

[raveit65]

@alexarnaud
Do you like to test this or should i merge it?
And feel free to test developer release before 1.24 to avoid such a pain and blaming us when the child is fallen into the wells.

[alexarnaud]

Le 08/05/2019 à 21:48, raveit65 a écrit :

@alexarnaud <https://github.com/alexarnaud> Do you like to test this or should i merge it?

You can merge it.

And feel free to test developer release before 1.24 to avoid such a pain and blaming us when the child is fallen into the wells.

I'm not currently on version 1.22, I've just reported an issue reported on the Orca mailing list to help impacted blind users. I never blame you, I know everyone here make his best to help improving Mate with his personal constraints. Best regards, Alex.

[raveit65]

Sigh,
i am only saying that it would helpful to test developer release before the release instead of filing out reports when it is broken for you.
Accessibility support is a sensible area or not?

[alexarnaud]

Le 09/05/2019 à 13:07, raveit65 a écrit :

Accessibility support is a sensible area or not?

It is. We'd be OK for testing Mate development branch if you provide a Debian repository or a daily snapshot to use it. Does it exist ? Best regards, Alex.

[raveit65]

Sorry, i am fedora maintainer and i am not responsible for your missing test environment ;)

[cwendling]

Sigh,
i am only saying that it would helpful to test developer release before the release instead of filing out reports when it is broken for you.

It makes a lot of sense, but unfortunately there's not enough people testing and actively caring about these issues to be able to follow and continuously test all components.

It would help to try and automate some testing in this area even though it's not trivial and there's not really a one-size-fits-all solution here, but there are things that can be done and that slowly make their way into some software, but it takes some efforts. Hopefully at some point there will be a solid enough basis to implement such tests broadly, and they'll be common enough to be naturally integrated in many places :)

[raveit65]

Normally i am pushing developer releases to fedora rawhide. I think i will start it again for fedora next release (f31).
Same can be done for debian, but that's not my job.

[lukefromdc]

Now I need to add support for opening the slider in the mate-volume-control panel applet by the return key

[lukefromdc]

I have found getting that slider in mate-media's new volume control applet to pop up on "return" to be royally difficult due to the focus being on a parent object of the object that actually can pop up the slider. The "division of labor" in that applet has caused me to spend a whole day on this a few days back with nothing to show for it. I could not even get a message in syslog out of it on a keystroke.

[lukefromdc]

We can continue discussion of the mate-media panel applet slider/return issue at
mate-desktop/mate-media#131

[lukefromdc]

Clock works fine, both raises and lowers it, though the code to close the calendar on as well no longer seems to work

[raveit65]

@alexarnaud

Le 09/05/2019 à 13:07, raveit65 a écrit :

Accessibility support is a sensible area or not?

It is.

We'd be OK for testing Mate development branch if you provide a Debian
repository or a daily snapshot to use it.

Does it exist ?

You can use this repo for testing 1.23. x packages.
https://copr.fedorainfracloud.org/coprs/raveit65/MATE-1.23.x/

[kloczek]

BTW is any plan to start releasing updated versions mate dist tar balls?

Looks like only one mate package has been updated in last +2 months.

[alexarnaud]

@kloczek What are you talking about exactly? Which issue do you have in mind? If this is this one is already fixed for a while on much distribution and release.

[kloczek]

I'm talking about Mate desktop source code distribution.

[alexarnaud]

This is not the place to discuss about this.

If you don't care of this particular bug, please comment on the bug you have on current release or open a new one explaining what you expect and why.

Thanks in advance.

[kloczek]

So this is not the place to discuss releasing new version of the mate-panel with fixed recently bugs?

No offence but did you notice that now one is discusiing anywhere where new releases will be made?

That pareticulat bug is very annoing. Why after fixing something like this is not made new release?
Look on other desktop source trees and you will find that recently they are trying to make at least one time a month bugfix releases.

[alexarnaud]

This issue is just for discussing "Fix panel applet keyboard focus trap". If you encounter it in latest Mate 1.24 release feel free to give me the steps to reproduce it and I'll do my best to make it figured it out.

Thanks.

[kloczek]

Thank you very much for provide "answer" on my question.

PS. I have nothing to do with that bug and really I have nothing to explain about it (it if is not obviouse yet).