Develop #1054
Open
Develop #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Nov 14, 2023
requirements.txt
Outdated
| flake8==5.0.4 |
There was a problem hiding this comment.
Do not change the requirements.txt, this file should be absent in the pull request.
requirements.txt
Outdated
| flake8-variables-names==0.0.5 | ||
| pep8-naming==0.13.2 | ||
| pytest==7.1.3 |
There was a problem hiding this comment.
Exclude the content of the __pycache__ directory and the directory itself from the PR.
|
Якщо неправильно, то підскажіть де може знаходитися pycache |
Polyakiv-Andrey
suggested changes
Nov 14, 2023
|
Ніби все правильно зробив |
Dimosphen1
suggested changes
Nov 14, 2023
Dimosphen1
suggested changes
Nov 15, 2023
| # write your code here | ||
| sorted_variables = { | ||
| "mutable": [ | ||
| my_favourite_films, |
There was a problem hiding this comment.
The issue is not resolved, your pull request should not contain files other than app/main.py. Visit a Q&A session to resolve this issue and request another review after other files are not present.
Olevsky-Ivan
force-pushed
the
develop
branch
from
14b04fa to
648871f
Compare
pavlejviki
approved these changes
Nov 18, 2023
| @@ -5,3 +5,4 @@ | |||
| .DS_Store | |||
| venv/ | |||
| .pytest_cache/ | |||
| tests/__pycache__/test_main.cpython-39-pytest-7.1.3.pyc | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.