Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stopwatch #3572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add stopwatch #3572

wants to merge 2 commits into from

Conversation

BTakhaiev
Copy link

Replace <your_account> with your GitHub username and copy the links to the Pull Request description:

Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution is almost there, but there are a few critical issues that need to be addressed to meet the task requirements. The animation for the seconds hand should not use steps(60, end) and should maintain an even speed. Also, ensure the BEM modifier speed-up is correctly applied to both elements, and adjust the animation durations as specified. Keep up the good work, and with these adjustments, you'll be all set! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@BTakhaiev
Copy link
Author

Replace <your_account> with your GitHub username and copy the links to the Pull Request description:

Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

1 similar comment
@BTakhaiev
Copy link
Author

Replace <your_account> with your GitHub username and copy the links to the Pull Request description:

Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

}
}

@keyframes minut {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@keyframes minut {
@keyframes rotate {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants