-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stopwatch #3572
base: master
Are you sure you want to change the base?
add stopwatch #3572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution is almost there, but there are a few critical issues that need to be addressed to meet the task requirements. The animation for the seconds hand should not use steps(60, end)
and should maintain an even speed. Also, ensure the BEM modifier speed-up
is correctly applied to both elements, and adjust the animation durations as specified. Keep up the good work, and with these adjustments, you'll be all set! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
} | ||
} | ||
|
||
@keyframes minut { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keyframes minut { | |
@keyframes rotate { |
Replace
<your_account>
with your GitHub username and copy the links to thePull Request
description:Copy this
Checklist
to thePull Request
description after links, and put- [x]
before each point after you checked it.Typical Mistakes
from theBEM
lesson theory are checked.