-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #3564
base: master
Are you sure you want to change the base?
add solution #3564
Conversation
DeJisk
commented
Jan 1, 2025
- DEMO LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve your pull request. Specifically, the speed-up
modifier for the minutes hand needs to be corrected to 600s
(10 minutes), and the BEM modifier should be applied according to conventions. Additionally, ensure the HTML structure allows for testing without the speed-up
modifier. Once these are resolved, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on making the necessary adjustments! 🎉 Your solution now meets the task requirements and constraints. Here are some key points from the review:
- SCSS Implementation: You've correctly implemented the keyframes using
from/to
with thetransform
property to rotate the hands of the stopwatch. - HTML Structure: The HTML file includes the required
stopwatch
class element, and thespeed-up
modifier is applied to both the minutes and seconds hands for testing purposes. - BEM Modifier: The
speed-up
modifier is correctly implemented in the SCSS file for both the minutes and seconds hands, with the correct animation durations of600s
for the minutes hand and10s
for the seconds hand. - CSS Animations: The animations are set to infinite, and the
steps
function is used for the minutes hand as required. - Centering and Sizing: The stopwatch is centered on the page, and the dimensions and styles match the task description.
While there were some issues initially, you've addressed them effectively. Moving forward, ensure that critical requirements, like the animation
duration for the stopwatch__minutes-hand--speed-up
, are implemented correctly to avoid similar issues. Keep up the great work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<div class="stopwatch"> | ||
<div class="stopwatch__center"></div> | ||
<div | ||
class="stopwatch__minutes-hand stopwatch__minutes-hand--speed-up" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stopwatch__minutes-hand--speed-up
modifier should be set to 600s
(10 minutes) according to the task requirements. Please ensure this is correctly implemented.
animation: hand-go 3600s steps(60) infinite; | ||
|
||
&--speed-up { | ||
animation: hand-go 600s steps(60) infinite; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animation
duration for the stopwatch__minutes-hand--speed-up
should be 600s
to match the task requirements for a 10-minute cycle.