product card 24.12.2024 #5114
Open
product card 24.12.2024 #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Great job on your implementation! 🎉 Your code meets the task requirements and is well-structured. Just make sure that the Parcel bundler is correctly set up to handle SCSS files, as this will ensure everything compiles smoothly without runtime issues. Keep up the excellent work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
23
to
26
| <link | ||
| rel="stylesheet" | ||
| href="./styles/index.scss" | ||
| /> |
There was a problem hiding this comment.
Ensure that the Parcel bundler is set up to handle SCSS files correctly, as you are linking to an SCSS file directly. This is allowed, but make sure the setup is correct to avoid runtime issues.
volodymyr-soltys97
suggested changes
Dec 26, 2024
src/index.html
Outdated
Comment on lines
52
to
58
| <div class="star__line star__line--0"> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| </div> |
There was a problem hiding this comment.
Fix classes and implement the modifier logic
Suggested change
| <div class="star__line star__line--0"> | |
| <div class="star__style star__style--passive"></div> | |
| <div class="star__style star__style--passive"></div> | |
| <div class="star__style star__style--passive"></div> | |
| <div class="star__style star__style--passive"></div> | |
| <div class="star__style star__style--passive"></div> | |
| </div> | |
| <div class="stars stars--4"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| </div> |
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <div class="card__cord-image"> |
There was a problem hiding this comment.
Do you need this wrapper for image?
Suggested change
| <div class="card__cord-image"> |
There was a problem hiding this comment.
Without it I couldn't center the image.
src/index.html
Outdated
Comment on lines
60
to
88
| <div class="star__line star__line--1"> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| </div> | ||
|
|
||
| <div class="star__line star__line--2"> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| </div> | ||
|
|
||
| <div class="star__line star__line--3"> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| <div class="star__style star__style--passive"></div> | ||
| </div> | ||
|
|
||
| <div class="star__line star__line--4"> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--active"></div> | ||
| <div class="star__style star__style--active"></div> |
src/index.html
Outdated
| </div> | ||
|
|
||
| <button | ||
| class="card__buy-button button" |
There was a problem hiding this comment.
Suggested change
| class="card__buy-button button" | |
| class="card__button" |
VitaliyBondarenko1982
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.