-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5087
base: master
Are you sure you want to change the base?
add task solution #5087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:
-
Card Width: The card width is currently set to 167px, but it should be 200px including the border. This is a core requirement that needs to be corrected.
-
SCSS Variables: Ensure that all main values are defined as variables in a separate file, as this is a requirement for maintainability.
-
Image Paths: The
background-image
paths instars.scss
should be relative toindex.scss
, starting with../images
, but they currently start with/src/images
. This needs to be corrected to ensure the images load properly. -
Unused Files: The
cash.scss
,rating.scss
, andimage.scss
files are not mentioned in the task description and may not be needed. Consider removing them if they are not required. -
Font Usage: Verify that the correct font from Google Fonts is being used as per the task description.
Please address these issues to meet the core requirements of the task. Once these changes are made, we can proceed with the approval. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/styles/blocks/card.scss
Outdated
position: absolute; | ||
bottom: 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'bottom' property value should have a unit (e.g., 'px'). Without a unit, it may not be applied correctly. Consider changing 'bottom: 16;' to 'bottom: 16px;'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Pull Request has been reviewed and approved! 🎉
You've done a great job addressing the task requirements, particularly in setting the card width correctly and linking the SCSS file. The use of variables for maintainability is well-implemented, and the image paths are mostly correct. However, there are a few areas for improvement:
- Maintainability: Ensure all color, padding, and size values are defined as variables in a separate file. This will enhance the maintainability of your code.
- Image Paths: Verify that all image paths are correct and relative to the SCSS or HTML file locations.
- Unused Files: Consider removing any unnecessary files like
cash.scss
,rating.scss
, andimage.scss
if they are not required for the task.
These improvements will help you maintain a clean and efficient codebase. Keep up the good work, and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
href="https://fonts.googleapis.com/css2?family=Poppins&family=Roboto:wght@400;500;700&display=swap" | ||
rel="stylesheet" | ||
/> | ||
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SCSS file is linked correctly, which is acceptable as per the task requirements.
> | ||
<div class="image"> | ||
<img | ||
src="/src/images/imac.jpeg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image path should be relative to the HTML file. Consider changing the path from '/src/images/imac.jpeg' to '../images/imac.jpeg' to ensure the image loads correctly.
box-sizing: border-box; | ||
position: relative; | ||
text-align: justify; | ||
width: 200px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The card width is correctly set to 200px, which includes the border. This aligns with the task requirements.
text-align: justify; | ||
width: 200px; | ||
height: 407px; | ||
border: 1px solid $grey-star-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the color value for the border is defined as a variable in a separate file, as per the task requirements for maintainability.
font-weight: 500; | ||
font-size: 12px; | ||
line-height: 18px; | ||
color: $standart-black-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the color value is defined as a variable in a separate file, as per the task requirements for maintainability.
@@ -4,0 +1,7 @@ | |||
@import '/src/styles/blocks/variables'; | |||
@import '/src/styles/blocks/page'; | |||
@import '/src/styles/blocks/card'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the import path for the card styles is correct and relative to the SCSS file location. The current path '/src/styles/blocks/card' should be './blocks/card' to align with the project structure.
@import '/src/styles/blocks/variables'; | ||
@import '/src/styles/blocks/page'; | ||
@import '/src/styles/blocks/card'; | ||
@import '/src/styles/blocks/image'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the import path for the image styles is correct and relative to the SCSS file location. The current path '/src/styles/blocks/image' should be './blocks/image' to align with the project structure.
@import '/src/styles/blocks/page'; | ||
@import '/src/styles/blocks/card'; | ||
@import '/src/styles/blocks/image'; | ||
@import '/src/styles/blocks/cash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the import path for the cash styles is correct and relative to the SCSS file location. The current path '/src/styles/blocks/cash' should be './blocks/cash' to align with the project structure.
@import '/src/styles/blocks/card'; | ||
@import '/src/styles/blocks/image'; | ||
@import '/src/styles/blocks/cash'; | ||
@import '/src/styles/blocks/rating'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the import path for the rating styles is correct and relative to the SCSS file location. The current path '/src/styles/blocks/rating' should be './blocks/rating' to align with the project structure.
@import '/src/styles/blocks/image'; | ||
@import '/src/styles/blocks/cash'; | ||
@import '/src/styles/blocks/rating'; | ||
@import '/src/styles/blocks/stars'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the import path for the stars styles is correct and relative to the SCSS file location. The current path '/src/styles/blocks/stars' should be './blocks/stars' to align with the project structure.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️