Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #5082

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add solution #5082

wants to merge 2 commits into from

Conversation

NataliiaVdovyna
Copy link

  • DEMO LINK

  • TEST REPORT LINK

    • there 2 BEM blocks card and stars each in their own file
    • SCSS Nesting is used for elements, modifiers and pseudo-classes
    • SCSS Variables are used for main values and placed in a separate file
    • all stars--N modifiers work as expected (Highlight first N stars)
    • Code follows all the Code Style Rules ❗️

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 18, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your implementation! 🎉 Your code meets the task requirements and is well-structured. The only minor issue is the missing stars--N modifiers in the stars.scss file, which you might want to address for full functionality. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

volodymyr-soltys97
volodymyr-soltys97 suggested changes Dec 18, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code.
This part of the task is incomplete
image

src/index.html Outdated
data-qa="card"
>
<section class="card__top">
<div class="card__top-image"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image isn't background, so you need to add image with the img tag

src/index.html Outdated
Comment on lines 48 to 49
<section class="stars">
<div class="stars__wrapper">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the modifier classes for active stars

Suggested change
<section class="stars">
<div class="stars__wrapper">
<section class="card__review">
<div class="stars stars--4">

src/index.html Outdated
class="price__link"
data-qa="hover"
>
<button class="price__button">Buy</button>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button class="price__button">Buy</button>
Buy

src/index.html
<div class="stars__text">Reviews: 5</div>
</section>

<section class="price">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant

Suggested change
<section class="price">

src/index.html Outdated
<div class="stars__star"></div>
</div>

<div class="stars__text">Reviews: 5</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the semantic tag for text

Suggested change
<div class="stars__text">Reviews: 5</div>
<p class="stars__text">Reviews: 5</p>

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Dec 19, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NataliiaVdovyna @VitaliyBondarenko1982 @volodymyr-soltys97 @mateacademy-ai-mentor