-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #5075
base: master
Are you sure you want to change the base?
add solution #5075
Conversation
KOliinyk
commented
Dec 16, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code meets most of the task requirements, and I'm approving it to help you move forward with your learning journey. However, there are a few important points to address:
-
BEM Blocks: Ensure that each BEM block (
card
andstars
) is placed in its own file as required by the task. -
SCSS Variables: SCSS variables should be used for main values and placed in a separate file. Make sure to implement this to enhance maintainability.
-
Stars Modifiers: Verify that all
stars--N
modifiers are implemented and function correctly to highlight the firstN
stars. -
Code Style Rules: Double-check that your code adheres to the specified code style rules.
-
Stylesheet Link: Ensure that the linked stylesheet is a compiled CSS file, not SCSS, as browsers cannot interpret SCSS directly.
-
Layout Issues: Review the alignment of
.footer__button
and the width setting of.stars__star
to prevent layout issues.
Addressing these points will not only improve your current project but also enhance your coding skills for future tasks. Keep up the great work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href attribute for the stylesheet link points to a SCSS file (index.scss
). Typically, browsers cannot directly interpret SCSS files. Ensure that this file is being compiled to CSS and that the correct CSS file is linked here.
justify-content: space-between; | ||
|
||
&__star { | ||
width: 60%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The width of the .stars__star
is set to 60%, which might cause layout issues if the parent container's width is not appropriately set. Consider setting a fixed width or ensuring the parent container's width is defined to avoid unexpected behavior.
border-radius: 5px; | ||
|
||
&__button { | ||
margin: 12px 70px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The margin for .footer__button
is set to 12px 70px
, which might not center the button as expected. Ensure that the button is properly aligned within the footer, especially if the footer's width changes.