Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #5072

Closed
wants to merge 2 commits into from
Closed

add solution #5072

wants to merge 2 commits into from

Conversation

KOliinyk
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:

  1. Stylesheet Linking: The HTML file currently links to an SCSS file (index.scss). SCSS needs to be compiled into CSS before it can be used in an HTML document. Please compile your SCSS to CSS and update the link accordingly.

  2. BEM Blocks: The task requires the use of two BEM blocks, card and stars. Currently, a header block is used instead of card. Please create and implement the card block as specified.

  3. SCSS Variables: The task specifies the use of SCSS variables for main values, which should be placed in a separate file. It seems this is missing, so please ensure SCSS variables are used and organized in a separate file.

  4. Stars Block: The stars block needs to be rewritten from the Stars task using SCSS. Please ensure it meets the requirements from the referenced task.

Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance. 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines 23 to 26
<link
rel="stylesheet"
href="./styles/index.scss"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet link references an SCSS file (index.scss). SCSS files need to be compiled into CSS before they can be used in an HTML document. Make sure to compile your SCSS to CSS and link the resulting CSS file here.

@KOliinyk KOliinyk closed this by deleting the head repository Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants