Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add card #5068

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add card #5068

wants to merge 2 commits into from

Conversation

KateShepel
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Hello! 😊 You've done a great job implementing the task requirements, and your attention to detail with BEM conventions and SCSS structuring is commendable. However, there's a critical issue that needs to be addressed before we can approve the pull request:

  • Stylesheet Link: The HTML file is currently linking to a .scss file (href="./styles/index.scss"). Browsers cannot directly interpret SCSS files; they need to be compiled into CSS. Please ensure that the SCSS file is compiled to a CSS file and update the link to point to the resulting CSS file instead.

Once you address this issue, your solution will be ready for approval. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines 23 to 26
<link
rel="stylesheet"
href="./styles/index.scss"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet link is pointing to a .scss file (href="./styles/index.scss"). Typically, browsers cannot directly interpret SCSS files. Ensure that this SCSS file is compiled to a CSS file and update the link to point to the resulting CSS file instead.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on your submission! 🎉 Your code is well-structured and follows best practices, such as using BEM conventions and SCSS variables. Here are some key points and areas for improvement:

  • HTML Structure: The HTML file is well-organized and follows semantic conventions. However, there's a critical issue with the stylesheet link. It's currently pointing to a .scss file, which browsers cannot interpret directly. Please ensure that the SCSS file is compiled into a CSS file and update the link accordingly.

  • SCSS Organization: Your SCSS files are well-structured, making good use of variables, imports, and BEM conventions. This enhances maintainability and readability. Just remember to compile your SCSS to CSS for browser compatibility.

  • Variables File: The variables file is well-organized, providing a centralized location for managing styling properties, which is excellent for maintainability and consistency.

  • Final Conclusion: Your implementation meets the task requirements and constraints. You've addressed previous issues effectively, and the code includes all necessary components and attributes.

While the decision is to APPROVE your pull request to help you move forward with your learning, please review the comments and address the critical issue regarding the stylesheet link in future projects. Keep up the great work, and continue to learn and improve! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines 23 to 25
<link
rel="stylesheet"
href="./styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is pointing to a .scss file (./styles/index.scss). Browsers cannot directly interpret SCSS files; they need to be compiled into CSS. Please ensure that the SCSS file is compiled to a CSS file and update the link to point to the resulting CSS file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants