-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #5066
base: master
Are you sure you want to change the base?
add solution #5066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code meets the core requirements of the task, and you've done well with the HTML structure and SCSS organization. There are a few minor issues to address, such as ensuring all SCSS variables are defined and updating the stylesheet link to point to a compiled CSS file. These are small tweaks that can enhance your project, but they don't impact the overall functionality. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" | ||
rel="stylesheet" | ||
/> | ||
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stylesheet link is pointing to a SCSS file (index.scss
). Browsers cannot directly interpret SCSS files; they need to be compiled into CSS first. Ensure that index.scss
is compiled to index.css
, and update the href attribute to point to the compiled CSS file.
font-family: Roboto, sans-serif; | ||
font-weight: 400; | ||
font-style: normal; | ||
color: $main-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-color
is used for the color
property. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid color value before using it.
@@ -0,0 +1,75 @@ | |||
.card { | |||
box-sizing: border-box; | |||
height: $card-height; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $card-height
is used for the height
property. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid value before using it.
.card { | ||
box-sizing: border-box; | ||
height: $card-height; | ||
width: $card-width; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $card-width
is used for the width
property. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid value before using it.
box-sizing: border-box; | ||
height: $card-height; | ||
width: $card-width; | ||
border: 1px solid $border-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $border-color
is used for the border
property. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid color value before using it.
&__image { | ||
display: block; | ||
height: $image-height; | ||
width: $image-width; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $image-width
is used for the width
property of the &__image
class. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid value before using it.
font-size: 12px; | ||
font-weight: 500; | ||
line-height: 18px; | ||
color: $main-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-color
is used for the color
property of the &__title
class. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid color value before using it.
margin-top: 0; | ||
font-size: 10px; | ||
line-height: 14px; | ||
color: $secondary-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $secondary-color
is used for the color
property of the &__code
class. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid color value before using it.
|
||
&__title { | ||
font-size: 12px; | ||
color: $secondary-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $secondary-color
is used for the color
property of the &__title
class. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid color value before using it.
&__cost { | ||
font-size: 16px; | ||
font-weight: 700; | ||
color: $main-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-color
is used for the color
property of the &__cost
class. Ensure that this variable is defined elsewhere in your SCSS files. If it's not defined, you need to declare it with a valid color value before using it.
DEMO LINK
TEST REPORT LINK
[Х] there 2 BEM blocks
card
andstars
each in their own file[Х] SCSS Nesting is used for
elements
,modifiers
andpseudo-classes
[Х] SCSS Variables are used for main values and placed in a separate file
[Х] all
stars--N
modifiers work as expected (Highlight firstN
stars)[Х] Code follows all the Code Style Rules ❗️