-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5027
Develop #5027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:
-
BEM Blocks Separation: The task requires the
card
andstars
BEM blocks to be in separate files. This separation is crucial for maintaining a modular and scalable codebase. -
SCSS Variables File: While you have used SCSS variables, they need to be placed in a separate file as per the task requirements. This helps in maintaining consistency and ease of updates across stylesheets.
-
Stars Block Implementation: The
stars
block from the previous task needs to be rewritten in SCSS and clearly integrated into the current implementation. -
Empty
product__header.scss
File: This file is currently empty and should either be completed with the necessary styles or removed if not needed. -
Stylesheet Link: The HTML file links to an SCSS file. Ensure that this is processed into a CSS file or update the link to point to the correct CSS file.
These changes are necessary to meet the core requirements of the task and ensure the functionality and maintainability of the code. Once these issues are resolved, we can proceed with the approval. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/index.html
Outdated
@@ -11,8 +11,69 @@ | |||
rel="stylesheet" | |||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stylesheet link is pointing to an SCSS file (index.scss
). Ensure that this file is being processed into CSS, or change the link to point to the resulting CSS file (e.g., index.css
).
|
||
html { | ||
font-family: Roboto, serif; | ||
font-weight: 400, 500, 700; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-weight
property should not have multiple values like 400, 500, 700
. Instead, specify a single value or use separate rules for different elements if needed.
src/styles/index.scss
Outdated
&:hover, | ||
&:hover &-title { | ||
color: #00acdc; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hover styles for &:hover &-title
might not work as intended due to specificity issues. Ensure that the selector correctly targets the intended element. Consider using a more specific selector if necessary.
|
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️