Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5027

Closed
wants to merge 3 commits into from
Closed

Develop #5027

wants to merge 3 commits into from

Conversation

Vovanchu
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:

  1. BEM Blocks Separation: The task requires the card and stars BEM blocks to be in separate files. This separation is crucial for maintaining a modular and scalable codebase.

  2. SCSS Variables File: While you have used SCSS variables, they need to be placed in a separate file as per the task requirements. This helps in maintaining consistency and ease of updates across stylesheets.

  3. Stars Block Implementation: The stars block from the previous task needs to be rewritten in SCSS and clearly integrated into the current implementation.

  4. Empty product__header.scss File: This file is currently empty and should either be completed with the necessary styles or removed if not needed.

  5. Stylesheet Link: The HTML file links to an SCSS file. Ensure that this is processed into a CSS file or update the link to point to the correct CSS file.

These changes are necessary to meet the core requirements of the task and ensure the functionality and maintainability of the code. Once these issues are resolved, we can proceed with the approval. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated
@@ -11,8 +11,69 @@
rel="stylesheet"
href="./styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet link is pointing to an SCSS file (index.scss). Ensure that this file is being processed into CSS, or change the link to point to the resulting CSS file (e.g., index.css).


html {
font-family: Roboto, serif;
font-weight: 400, 500, 700;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight property should not have multiple values like 400, 500, 700. Instead, specify a single value or use separate rules for different elements if needed.

Comment on lines 197 to 200
&:hover,
&:hover &-title {
color: #00acdc;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hover styles for &:hover &-title might not work as intended due to specificity issues. Ensure that the selector correctly targets the intended element. Consider using a more specific selector if necessary.

@Vovanchu
Copy link
Author

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

@Vovanchu Vovanchu closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants