Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5875

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #5875

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da961dc
Inicial
Ludson130 Dec 27, 2024
0a95356
Solução 1
Ludson130 Dec 27, 2024
efecbdf
Solução 2
Ludson130 Dec 27, 2024
df65bd8
teste 3
Ludson130 Dec 31, 2024
ee819bb
teste final
Ludson130 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
- name: Upload HTML report(backstop data)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: backstop_data
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,12 @@
"keywords": [],
"author": "Mate Academy",
"license": "GPL-3.0",
"dependencies": {},
"devDependencies": {
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/backstop-config": "latest",
"@mate-academy/bemlint": "latest",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^1.9.12",
"@mate-academy/stylelint-config": "latest",
"backstopjs": "6.3.23",
"jest": "^29.7.0",
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://Ludson130.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://Ludson130.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
99 changes: 93 additions & 6 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,109 @@
<!doctype html>
<html lang="en">
<head>
<link
rel="stylesheet"
href="Style.css"
/>
<meta charset="UTF-8" />
<meta
name="viewport"
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"
/>
<meta
http-equiv="X-UA-Compatible"
content="ie=edge"
<title>Document</title>
<link rel="styleet" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the rel attribute value. It should be stylesheet instead of styleet.

<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com/"
/>
<title>Moyo header</title>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;700&display=swap"
rel="stylesheet"
href="./style.css"
/>
</head>
<body>
<h1>Moyo header</h1>
<header class="header">
<nav>
<ul class="menu">
<li class="element logo">
<a href=" ">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute in this anchor tag is empty. Consider providing a valid URL or removing the attribute if it's not needed.

<img
src="images/logo.png"
alt="MOYO"
/>
</a>
</li>
<li class="element">
<a
class="link is-active apple"
href=" "
>
Apple
</a>
</li>
<li class="element">
<a
class="link"
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is a placeholder. Please replace it with the actual URL for the 'Samsung' link.

>
Samsung
</a>
</li>
<li class="element">
<a
class="link"
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is a placeholder. Please replace it with the actual URL for the 'Smartphones' link.

>
Smartphones
</a>
</li>
<li class="element">
<a
data-qa="hover"
class="link blue"
href="#"
>
Laptops & Computers
</a>
</li>
<li class="element">
<a
class="link"
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is a placeholder. Please replace it with the actual URL for the 'Gadgets' link.

>
Gadgets
</a>
</li>
<li class="element">
<a
class="link"
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is a placeholder. Please replace it with the actual URL for the 'Tablets' link.

>
Tablets
</a>
</li>
<li class="element">
<a
class="link"
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is a placeholder. Please replace it with the actual URL for the 'Photo' link.

>
Photo
</a>
</li>
<li class="element">
<a
class="link"
href="#"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is set to #, which is a placeholder. Please replace it with the actual URL for the 'Video' link.

>
Video
</a>
</li>
</ul>
</nav>
</header>
</body>
</html>
60 changes: 60 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,63 @@
body {
--nav-color: #00acdc;

margin: 0;
border: 0;
font-family: Roboto, serif;
background-color: lightslategray;
text-transform: uppercase;
justify-content: center;
align-items: center;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justify-content and align-items properties are typically used with flexbox or grid containers. Since body is not set as a flex or grid container, these properties will have no effect.

}

.header {
background-color: #fff;
display: flex;
flex-direction: row;
justify-content: center;
height: 60px;
align-items: center;
}

.element {
text-decoration: none;
display: inline-flex;
}

.logo {
margin-right: 25px;
height: 40px;
width: 40px;
position: absolute;
left: 50px;
top: 10px;
}

a:hover {
color: var(--nav-color);
text-decoration: underline;
}

.link {
text-decoration: none;
height: 15px;
font-size: 12px;
font-weight: 500px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight property should be a numeric value (e.g., 400, 500, 700) or one of the keyword values (e.g., normal, bold). The current value '500px' is incorrect and should be corrected.

}

.is-active {
color: var(--nav-color);
}

.is-active::after {
width: 37px;
height: 4px;
border-radius: 8px;
position: absolute;
background-color: var(--nav-color);
bottom: 0;
}

.blue{
color: var(--nav-color);
}
Loading