Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5865

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

greyhoundIlya
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! It looks like there are a few critical issues that need to be addressed before we can approve this pull request. The most important one is the typo in the class name 'conteiner', which should be corrected to 'container' in both the HTML and CSS files to ensure the styles are applied correctly. Additionally, there are several other issues that need attention, such as using a CSS variable for the blue color, ensuring text is styled to uppercase using CSS, and improving the semantic structure of your HTML. Please make these changes, and feel free to reach out if you need any help! 😊 Keep up the great work, and I'm confident you'll nail it with the next iteration!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated
background-color: #fff;
}

.conteiner {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the class name 'conteiner'. It should be 'container'. This should be consistent with the HTML to ensure the styles are applied correctly.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort on updating the HTML and CSS files! 🎉 While the class name 'container' has been corrected, there are still a few areas that need attention to fully meet the task requirements.

  1. CSS Variable for Blue Color: It's important to define a CSS variable for the blue color #00acdc to ensure consistency and easier maintenance across your styles.

  2. Text Uppercase Styling: Instead of hardcoding text in uppercase in the HTML, use the text-transform: uppercase; CSS property to style navigation items and other text elements like 'VIDEO', 'PHOTO', 'TABLETS', etc. This will enhance the semantic quality of your HTML.

  3. Semantic HTML Structure: Ensure all elements are appropriately semantic. For instance, reconsider the use of the <h1> tag for the title "Moyo header" if it doesn't serve a semantic purpose.

  4. CSS Reset: Avoid using the universal selector * for resetting margins and paddings due to performance concerns. A more targeted approach is recommended.

  5. Missing Files: Make sure all required files, such as images, are included in the repository. The HTML references an image at /src/images/logo.png, which should be present.

These improvements will not only enhance the code quality but also align it with best practices. Keep up the good work and continue learning from these experiences. Addressing these points will be crucial for your future projects. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

href="#"
class="is-active"
>
APPLE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text 'APPLE' is hardcoded in uppercase. Consider using CSS to style the text to uppercase instead of hardcoding it in the HTML. This will make your HTML more semantic and easier to maintain.

APPLE
</a>
</li>
<li><a href="#">SAMSUNG</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text 'SAMSUNG' is hardcoded in uppercase. Consider using CSS to style the text to uppercase instead of hardcoding it in the HTML.

</a>
</li>
<li><a href="#">SAMSUNG</a></li>
<li><a href="#">SMARTPHONES</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text 'SMARTPHONES' is hardcoded in uppercase. Consider using CSS to style the text to uppercase instead of hardcoding it in the HTML.

href="#"
data-qa="hover"
>
LAPTOPS & COMPUTERS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text 'LAPTOPS & COMPUTERS' is hardcoded in uppercase. Consider using CSS to style the text to uppercase instead of hardcoding it in the HTML.

LAPTOPS & COMPUTERS
</a>
</li>
<li><a href="#">GADGETS</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text 'GADGETS' is hardcoded in uppercase. Consider using CSS to style the text to uppercase instead of hardcoding it in the HTML.

nav ul li a {
display: inline-block;
text-decoration: none;
color: #000;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a CSS variable for the color #000 to improve maintainability and consistency across your styles.

}

nav ul li a:hover {
color: #00acdc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a CSS variable for the color #00acdc to improve maintainability and consistency across your styles.

.is-active {
font-size: 12px;
position: relative;
color: #00acdc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a CSS variable for the color #00acdc to improve maintainability and consistency across your styles.

left: 0;
width: 100%;
height: 4px;
background-color: #00acdc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a CSS variable for the color #00acdc to improve maintainability and consistency across your styles.

height: 40px;
}

nav ul li a {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that the navigation items are displayed in uppercase, consider adding 'text-transform: uppercase;' to this selector. This will make your HTML more semantic by not requiring the text to be hardcoded in uppercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants