Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #612

wants to merge 1 commit into from

Conversation

Bulavskyi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the getHumanAge function! 🎉 Your code meets the task requirements and constraints, and the test cases are well-structured, covering a variety of scenarios. The only minor point to consider is whether the test case for ignoring the decimal part of the input is necessary, as the function is expected to handle integer inputs. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +27 to +28
test('should ignore decimal part of the input', () => {
expect(getHumanAge(15.7, 15.9)).toEqual([1, 1]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case for ignoring the decimal part of the input (getHumanAge(15.7, 15.9)) might not be necessary if the function is expected to handle only integer inputs, as per the task description. Consider whether this test aligns with the intended functionality of getHumanAge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants