Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #460

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add task solution #460

wants to merge 3 commits into from

Conversation

OlhaLishenko
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 2, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page:

  1. Change title on the page to Crazybaby
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Fix this error after submit form
image
  1. Add actual address for these links and open it in the new tab
image

@TarasHoliuk
Copy link

Great job! I like the animations on the site 🔥

But one more point should be improved:
image

All external links should be open in the new tab (it's a general rule)

TarasHoliuk
TarasHoliuk suggested changes Nov 3, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! One tiny comment

@OlhaLishenko
Copy link
Author

Thank you for feedback!

anastasiiavorobiova
anastasiiavorobiova approved these changes Nov 3, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
I love your animations and the idea of using dots on the hover
Looks really great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlhaLishenko @TarasHoliuk @volodymyr-soltys97 @anastasiiavorobiova