Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

밈 기본 API 수정 #3

Merged
merged 15 commits into from
Jun 18, 2024
Merged

밈 기본 API 수정 #3

merged 15 commits into from
Jun 18, 2024

Conversation

seohyun0120
Copy link
Collaborator

  • 패키지명 수정
  • startServer 구조 수정
    • 테스트코드에서 supertest로 app을 쓰기 위함
  • 타입 수정
    • IMeme: 애플리케이션 로직에 사용할 data 타입
    • IMemeDocument : MongoDB Documet 타입
    • IMeme.source: 필수 필드로 변경
  • API 수정
    • 밈 1개 조회: 찾지 못했을 때에 대한 예외처리
    • 밈 목록 조회, 오늘의 밈 조회: query parameter로 수정, 예외처리 추가

@seohyun0120 seohyun0120 requested review from pjw5521 and Hyun-git June 16, 2024 14:54
@seohyun0120 seohyun0120 mentioned this pull request Jun 16, 2024
Merged
Hyun-git
Hyun-git approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@Hyun-git Hyun-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳..!

pjw5521
pjw5521 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@pjw5521 pjw5521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 멋지네요 참고하겠습니다

@seohyun0120 seohyun0120 merged commit 65a8151 into develop Jun 18, 2024
1 check passed
@seohyun0120 seohyun0120 deleted the feature/fix-meme-api branch June 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyun-git Hyun-git Hyun-git approved these changes

@pjw5521 pjw5521 pjw5521 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seohyun0120 @pjw5521 @Hyun-git