Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] spotless 자동 apply 적용 #456

Closed
wants to merge 45 commits into from

Conversation

Ahn-seokjoo
Copy link
Collaborator

@Ahn-seokjoo Ahn-seokjoo commented Sep 5, 2023

작업 내역

Spotless apply 까지 자동 적용 ( check 실패시에만 apply 까지감)
Spotless check가 성공하면, apply는 안돌고 빌드가 돌음 ( 실패시에 build는 안돌음 )

문제점이 있긴한데

  1. spotless apply가 된 후에 ci가 다시 돌았으면 좋겠는데... 왜인지 안됨...
  2. check 실패시에 apply가 도는데, check는 실패이기 떄문에 ci 요약이 모두 x 표시로 나올 것임... 괜히 신경쓰임
  • 추후 머지시 사항
    수정 내역은 많이 없는데 푸시하면서 테스트 해봐야해서 .. 머지할때는 스쿼시 머지로 깔끔하게 넣으면 좋을 듯 합니다~

@Ahn-seokjoo Ahn-seokjoo added the 기능 기능 추가 label Sep 5, 2023
@Ahn-seokjoo Ahn-seokjoo self-assigned this Sep 5, 2023
@Ahn-seokjoo
Copy link
Collaborator Author

작동은 잘 하는데, 안스에서 show history할 때, 이름ㅇ ㅣ바뀌어 남을 것 같아서 .... 적용 안해도 됩니다~ 안할시에는 그냥 close 해즈세요 @Sookhee

Copy link
Collaborator

@jaeryo2357 jaeryo2357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 굳

@014967
Copy link
Contributor

014967 commented Jun 11, 2024

일단 close하고 추후에 reopen하겠습니다

@014967 014967 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants