-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] spotless 자동 apply 적용 #456
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint check + android ci
작동은 잘 하는데, 안스에서 show history할 때, 이름ㅇ ㅣ바뀌어 남을 것 같아서 .... 적용 안해도 됩니다~ 안할시에는 그냥 close 해즈세요 @Sookhee |
jaeryo2357
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 굳
일단 close하고 추후에 reopen하겠습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내역
Spotless apply 까지 자동 적용 ( check 실패시에만 apply 까지감)
Spotless check가 성공하면, apply는 안돌고 빌드가 돌음 ( 실패시에 build는 안돌음 )
문제점이 있긴한데
수정 내역은 많이 없는데 푸시하면서 테스트 해봐야해서 .. 머지할때는 스쿼시 머지로 깔끔하게 넣으면 좋을 듯 합니다~