Feat: Edit InviteLink #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invite link의 default mapRole을 WRITE -> READ로 변경 - invite link 생성할 때, mapRole을 파라미터로 추가
sally0226
commented
Sep 3, 2024
| import { UserMapRole, UserMapRoleValueType } from 'src/entities/index'; | ||
|
|
||
| export class CreateInviteLinkDto { | ||
| @IsEnum([UserMapRole.WRITE, UserMapRole.READ]) |
There was a problem hiding this comment.
ADMIN으로 초대할 수 없도록 제한
There was a problem hiding this comment.
오잉! 우리 READ로만 일단 가기로 하지 않았었나요?
확장성을 위한 설계인가요?
There was a problem hiding this comment.
맞습니당~~ 기본이 READ고 WRITE로도 초대링크 생성할 수 있게 열어놔쓰예
Ho-s
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
For what purpose
고도화 기능 구현
Key changes
To reviewers
Screenshots